fix: prevent accidental pressing of buttons in overlay header when the overlay is not visible #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reen, progress bar) when the overlay is not visible
|
Hi, thank you for your contribution! |
|
Hi @ihmpavel, could you please publish a new npm minor with the two fixes by the end of next week? |
|
Hi, please use version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the header to contain the playback speed controls.
As of now, the controls are clicked even if the overlay is not visible, with no perceivable feedback apart from the speed change (the overlay does not show either, since the press event is captured by the button).
I applied the fix using the same approach already used for the controls section of the player.
Closes #725