Uses iterable coder for windows and copies all of timestamp encoding …

…specification.
iht · Apr 8, 2020 · 3038900 · 3038900
1 parent 964c307
commit 3038900
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/model/pipeline/src/main/proto/beam_runner_api.proto b/model/pipeline/src/main/proto/beam_runner_api.proto
@@ -745,11 +745,21 @@ message StandardCoders {
     //   timestamp - A big endian 8 byte integer representing millis-since-epoch.
     //     The encoded representation is shifted so that the byte representation
     //     of negative values are lexicographically ordered before the byte
-    //     representation of positive values.
+    //     representation of positive values. This is typically done by
+    //     subtracting -9223372036854775808 from the value and encoding it as a
+    //     signed big endian integer. Example values:
     //
-    //   windows - For windows [w1...wN], the encoding is
-    //       fixed32(N) encode(w1) ... encode(wN)
-    //     where the windows are encoded using the supplied window coder.
+    //     -9223372036854775808: 00 00 00 00 00 00 00 00
+    //                     -255: 7F FF FF FF FF FF FF 01
+    //                       -1: 7F FF FF FF FF FF FF FF
+    //                        0: 80 00 00 00 00 00 00 00
+    //                        1: 80 00 00 00 00 00 00 01
+    //                      256: 80 00 00 00 00 00 01 00
+    //      9223372036854775807: FF FF FF FF FF FF FF FF
+    //
+    //   windows - The windows are encoded using the beam:coder:iterable:v1
+    //     format, where the windows are encoded using the supplied window
+    //     coder.
     //
     //   pane - The first byte of the pane info determines which type of
     //     encoding is used, as well as the is_first, is_last, and timing