Changed @sondr3/minitest to be a peer dependency #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In a Node project, when
@sondr3/minitest
is installed as a dependency, we can run its executable (calledmt
) to run tests easily:@codemod-utils/tests@v0.2.5
(and earlier versions) had@sondr3/minitest
as a dependency so that the consuming project wouldn't need to install it themselves. However, I couldn't figure out how to update thetest
script, i.e. how to replace the commandmt
withnode_modules/<some path>/mt
.What changed?
For simplicity (that is, allow the
test
script to continue to show themt
command), we'll ask the consuming project to install@sondr3/minitest
as a development dependency. This already happens when we use@codemod-utils/cli
to create a codemod project.In effect, removing
@sondr3/minitest
as a dependency from@codemod-utils/tests
will prevent the consuming project from potentially installing two versions of@sondr3/minitest
.