Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary eslint-disable comments in the main tutorial #72

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Sep 14, 2023

Background

In #71, I updated @codemod-utils/cli so that the eslint configuration is relaxed. This means, by default, codemod projects rely on @typescript-eslint's recommended rules (instead of recommended-type-checking).

@ijlee2 ijlee2 added the enhance: documentation Issue asks for better documentation (e.g. README, code, tests) label Sep 14, 2023
@ijlee2 ijlee2 changed the title Updated tutorial by removing eslint-disable comments Removed unnecessary eslint-disable comments in the main tutorial Sep 14, 2023
```diff
+ /* eslint-disable @typescript-eslint/no-unsafe-member-access */
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijlee2 ijlee2 marked this pull request as ready for review September 14, 2023 10:31
@ijlee2 ijlee2 merged commit 52651e3 into main Sep 14, 2023
2 checks passed
@ijlee2 ijlee2 deleted the update-tutorial branch September 14, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: documentation Issue asks for better documentation (e.g. README, code, tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant