Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JSDoc to @codemod-utils/files #77

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Added JSDoc to @codemod-utils/files #77

merged 6 commits into from
Oct 5, 2023

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Oct 5, 2023

Description

I added JSDoc to @codemod-utils/files so that end-developers have an additional source for learning, besides the package's README.md and tests (both are unavailable offline) as well as its provided types (requires some familiarity with TypeScript). In addition, I updated the README.md to show more simple examples.

Note, the breaking label is due to unionize() being deprecated (it will be removed later).

Screenshots

Before:

We see the type information for findFiles but nothing else.

After:

In addition to type information, we see a detailed explanation for the inputs and outputs of findFiles, along with a few examples.

@ijlee2 ijlee2 added enhance: documentation Issue asks for better documentation (e.g. README, code, tests) enhance: code Issue asks for new feature or refactor breaking Breaking change will result in a new major version labels Oct 5, 2023
@ijlee2 ijlee2 marked this pull request as ready for review October 5, 2023 21:26
@ijlee2 ijlee2 merged commit a607251 into main Oct 5, 2023
2 checks passed
@ijlee2 ijlee2 deleted the add-jsdoc-to-files branch October 5, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change will result in a new major version enhance: code Issue asks for new feature or refactor enhance: documentation Issue asks for better documentation (e.g. README, code, tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant