Removed duplicated code (#1)

* refactor: Allowed createOptions() to define src

* refactor: Simplified the folder structure

* chore: Added changeset

---------

Co-authored-by: ijlee2 <ijlee2@users.noreply.github.com>

.changeset/bright-emus-watch.md

@@ -0,0 +1,5 @@
+---
+"ember-codemod-remove-inject-as-service": patch
+---
+
+Removed duplicated code

src/index.ts

@@ -1,25 +1,8 @@
-import {
-  migrateEmberApp,
-  migrateEmberV1Addon,
-  migrateEmberV2Addon,
-} from './migration/index.js';
+import { createOptions, updateProject } from './steps/index.js';
 import type { CodemodOptions } from './types/index.js';
 
 export function runCodemod(codemodOptions: CodemodOptions): void {
-  switch (codemodOptions.projectType) {
-    case 'app': {
-      migrateEmberApp(codemodOptions);
-      break;
-    }
+  const options = createOptions(codemodOptions);
 
-    case 'v1-addon': {
-      migrateEmberV1Addon(codemodOptions);
-      break;
-    }
-
-    case 'v2-addon': {
-      migrateEmberV2Addon(codemodOptions);
-      break;
-    }
-  }
+  updateProject(options);
 }

src/steps/create-options.ts

@@ -0,0 +1,26 @@
+import type { CodemodOptions, Options } from '../types/index.js';
+
+function getSrc(projectType: CodemodOptions['projectType']): string[] {
+  switch (projectType) {
+    case 'app': {
+      return ['app/**/*.{js,ts}'];
+    }
+
+    case 'v1-addon': {
+      return ['addon/**/*.{js,ts}', 'tests/dummy/app/**/*.{js,ts}'];
+    }
+
+    case 'v2-addon': {
+      return ['src/**/*.{js,ts}'];
+    }
+  }
+}
+
+export function createOptions(codemodOptions: CodemodOptions): Options {
+  const { projectRoot, projectType } = codemodOptions;
+
+  return {
+    projectRoot,
+    src: getSrc(projectType),
+  };
+}

src/steps/index.ts

@@ -0,0 +1,2 @@
+export * from './create-options.js';
+export * from './update-project.js';

src/utils/steps/update-project.ts → src/steps/update-project.ts

@@ -3,11 +3,11 @@ import { join } from 'node:path';
 
 import { findFiles } from '@codemod-utils/files';
 
-import { Options } from '../../types/index.js';
+import { Options } from '../types/index.js';
 import { updateClass } from './update-project/update-class.js';
 
-export function updateProject(src: string[], options: Options): void {
-  const { projectRoot } = options;
+export function updateProject(options: Options): void {
+  const { projectRoot, src } = options;
 
   const filePaths = findFiles(src, {
     projectRoot,

src/types/index.ts

@@ -5,7 +5,7 @@ type CodemodOptions = {
 
 type Options = {
   projectRoot: string;
-  projectType: 'app' | 'v1-addon' | 'v2-addon';
+  src: string[];
 };
 
 export type { CodemodOptions, Options };

tests/helpers/shared-test-setups/my-app.ts

@@ -7,7 +7,7 @@ const codemodOptions: CodemodOptions = {
 
 const options: Options = {
   projectRoot: 'tmp/my-app',
-  projectType: 'app',
+  src: ['app/**/*.{js,ts}'],
 };
 
 export { codemodOptions, options };

tests/helpers/shared-test-setups/my-v1-addon.ts

@@ -7,7 +7,7 @@ const codemodOptions: CodemodOptions = {
 
 const options: Options = {
   projectRoot: 'tmp/my-v1-addon',
-  projectType: 'v1-addon',
+  src: ['addon/**/*.{js,ts}', 'tests/dummy/app/**/*.{js,ts}'],
 };
 
 export { codemodOptions, options };

tests/helpers/shared-test-setups/my-v2-addon.ts

@@ -7,7 +7,7 @@ const codemodOptions: CodemodOptions = {
 
 const options: Options = {
   projectRoot: 'tmp/my-v2-addon',
-  projectType: 'v2-addon',
+  src: ['src/**/*.{js,ts}'],
 };
 
 export { codemodOptions, options };

tests/steps/create-options/my-app.test.ts

@@ -0,0 +1,11 @@
+import { assert, test } from '@codemod-utils/tests';
+
+import { createOptions } from '../../../src/steps/index.js';
+import {
+  codemodOptions,
+  options,
+} from '../../helpers/shared-test-setups/my-app.js';
+
+test('steps | create-options > my-app', function () {
+  assert.deepStrictEqual(createOptions(codemodOptions), options);
+});

tests/steps/create-options/my-v1-addon.test.ts

@@ -0,0 +1,11 @@
+import { assert, test } from '@codemod-utils/tests';
+
+import { createOptions } from '../../../src/steps/index.js';
+import {
+  codemodOptions,
+  options,
+} from '../../helpers/shared-test-setups/my-v1-addon.js';
+
+test('steps | create-options > my-v1-addon', function () {
+  assert.deepStrictEqual(createOptions(codemodOptions), options);
+});

tests/steps/create-options/my-v2-addon.test.ts

@@ -0,0 +1,11 @@
+import { assert, test } from '@codemod-utils/tests';
+
+import { createOptions } from '../../../src/steps/index.js';
+import {
+  codemodOptions,
+  options,
+} from '../../helpers/shared-test-setups/my-v2-addon.js';
+
+test('steps | create-options > my-v2-addon', function () {
+  assert.deepStrictEqual(createOptions(codemodOptions), options);
+});