<Link>
does not ignore the onClick
event handler
#5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the
onClick
prop is discarded by the appliedonClick: (e) => visit(e)
handler.This fix ensures the handler is correctly passed down and ran. It then only runs the
visit()
function if the event wasn't default prevented, giving the user the possibility to cancel the visit by cancelling the click.Also added the types to match the props type.