Skip to content

Commit

Permalink
Java 11 migraiton: monostate
Browse files Browse the repository at this point in the history
  • Loading branch information
anuragagarwal561994 committed Apr 12, 2020
1 parent a142c06 commit 109d33c
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 14 deletions.
6 changes: 3 additions & 3 deletions monostate/src/main/java/com/iluwatar/monostate/App.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
*
* <p>In the following example, The {@link LoadBalancer} class represents the app's logic. It
* contains a series of Servers, which can handle requests of type {@link Request}. Two instances of
* LoadBalacer are created. When a request is made to a server via the first LoadBalancer the state
* LoadBalancer are created. When a request is made to a server via the first LoadBalancer the state
* change in the first load balancer affects the second. So if the first LoadBalancer selects the
* Server 1, the second LoadBalancer on a new request will select the Second server. If a third
* LoadBalancer is created and a new request is made to it, then it will select the third server as
Expand All @@ -43,8 +43,8 @@ public class App {
* @param args command line args
*/
public static void main(String[] args) {
LoadBalancer loadBalancer1 = new LoadBalancer();
LoadBalancer loadBalancer2 = new LoadBalancer();
var loadBalancer1 = new LoadBalancer();
var loadBalancer2 = new LoadBalancer();
loadBalancer1.serverRequest(new Request("Hello"));
loadBalancer2.serverRequest(new Request("Hello World"));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ public class LoadBalancer {
private static int lastServedId;

static {
int id = 0;
for (int port : new int[]{8080, 8081, 8082, 8083, 8084}) {
var id = 0;
for (var port : new int[]{8080, 8081, 8082, 8083, 8084}) {
SERVERS.add(new Server("localhost", port, ++id));
}
}
Expand Down Expand Up @@ -69,7 +69,7 @@ public synchronized void serverRequest(Request request) {
if (lastServedId >= SERVERS.size()) {
lastServedId = 0;
}
Server server = SERVERS.get(lastServedId++);
var server = SERVERS.get(lastServedId++);
server.serve(request);
}

Expand Down
3 changes: 1 addition & 2 deletions monostate/src/test/java/com/iluwatar/monostate/AppTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ public class AppTest {

@Test
public void testMain() {
String[] args = {};
App.main(args);
App.main(new String[]{});
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ public class LoadBalancerTest {

@Test
public void testSameStateAmongstAllInstances() {
final LoadBalancer firstBalancer = new LoadBalancer();
final LoadBalancer secondBalancer = new LoadBalancer();
final var firstBalancer = new LoadBalancer();
final var secondBalancer = new LoadBalancer();
firstBalancer.addServer(new Server("localhost", 8085, 6));
// Both should have the same number of servers.
assertEquals(firstBalancer.getNoOfServers(), secondBalancer.getNoOfServers());
Expand All @@ -55,18 +55,18 @@ public void testSameStateAmongstAllInstances() {

@Test
public void testServe() {
final Server server = mock(Server.class);
final var server = mock(Server.class);
when(server.getHost()).thenReturn("testhost");
when(server.getPort()).thenReturn(1234);
doNothing().when(server).serve(any(Request.class));

final LoadBalancer loadBalancer = new LoadBalancer();
final var loadBalancer = new LoadBalancer();
loadBalancer.addServer(server);

verifyZeroInteractions(server);

final Request request = new Request("test");
for (int i = 0; i < loadBalancer.getNoOfServers() * 2; i++) {
final var request = new Request("test");
for (var i = 0; i < loadBalancer.getNoOfServers() * 2; i++) {
loadBalancer.serverRequest(request);
}

Expand Down

0 comments on commit 109d33c

Please sign in to comment.