Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #1462 - Unit Test assertEquals parameters are reversed #1463

Merged
merged 2 commits into from
Aug 1, 2020
Merged

Fixes Issue #1462 - Unit Test assertEquals parameters are reversed #1463

merged 2 commits into from
Aug 1, 2020

Conversation

charlesfinley
Copy link
Contributor

@charlesfinley charlesfinley commented Aug 1, 2020

Opened for issue #1462

This PR fixes the assertEquals parameter order in the arrange-act-assert module.

assertEquals should be expected, actual. Currently these are reversed and in the incorrect order.

@iluwatar iluwatar self-assigned this Aug 1, 2020
@iluwatar iluwatar added this to the 1.23.0 milestone Aug 1, 2020
@iluwatar iluwatar merged commit 43569ec into iluwatar:master Aug 1, 2020
@iluwatar
Copy link
Owner

iluwatar commented Aug 1, 2020

@charlesfinley Thank you for your time and valuable contribution to this repository!

@iluwatar
Copy link
Owner

iluwatar commented Aug 1, 2020

@all-contributors please add @charlesfinley for code

@allcontributors
Copy link
Contributor

@iluwatar

I've put up a pull request to add @charlesfinley! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants