Minor refactorings and code style changes #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
npathai
commented
Oct 20, 2018
npathai
commented
- Removed several use of raw types
- Removed unnecessary throws clauses
- Used lambda expressions wherever applicable
- Used apt assertion methods for readability
- Use of try with resources wherever applicable
- Corrected incorrect order of assertXXX arguments
…re not needed, changed incorrect order of arguments in assertEquals
…raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments
IAmPramod
reviewed
Oct 21, 2018
| @@ -58,12 +59,12 @@ public void testFirstDataMapper() { | |||
| mapper.update(student); | |||
|
|
|||
| /* Check if student is updated in db */ | |||
| assertEquals(mapper.find(student.getStudentId()).get().getName(), "AdamUpdated"); | |||
| assertEquals("AdamUpdated", mapper.find(student.getStudentId()).get().getName()); | |||
There was a problem hiding this comment.
we should use student.getName() instead of AdamUpdated
There was a problem hiding this comment.
Fair point. I din't use student.getName() exactly but rather used a local variable at both places.
acyclic-visitor/src/test/java/com/iluwatar/acyclicvisitor/ConfigureForUnixVisitorTest.java
Outdated
Show resolved
Hide resolved
monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java
Outdated
Show resolved
Hide resolved
|
Looks good to me |
|
@iluwatar Done with review changes. |
|
@iluwatar Merging this PR as I got two 👍 s |
|
Thanks @npathai, well done 👍 |
|
@all-contributors please add @npathai for code ideas maintenance mentoring question review |
|
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected string in JSON at position 484 |
|
@all-contributors please add @npathai for code ideas maintenance mentoring question review |
|
I've put up a pull request to add @npathai! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.