New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#834 Fix dependency management issue for POM files #940

Merged

iluwatar merged 1 commit into iluwatar:master from perwramdemark:834

Oct 3, 2019

+1 −66

Contributor

perwramdemark commented Oct 3, 2019

Dependecy management should be setup in parent POM. Hence not needed in children projects.

Fix Maven build fail - Project "image-microservice" pom.xml lack of version field #834
Remove dependecy management for spring-boot in several children projects, redundant.
Removed version of spring-maven-plugin, redundant, version fetched from parent POM.


          iluwatar#834 Fix dependency management issue for POM files

829fc48

iluwatar approved these changes

View reviewed changes

iluwatar self-assigned this

iluwatar added the status: under review label

iluwatar added this to the 1.22.0 milestone

iluwatar merged commit 05d0f0b into iluwatar:master

Owner

iluwatar commented Oct 3, 2019

Looks good @perwramdemark, thanks for the fix!

perwramdemark deleted the 834 branch

October 6, 2019 08:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: under review