Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat project #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Reformat project #11

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 3, 2020

Finally :-)

Copy link
Owner

@ilyasidorchik ilyasidorchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are styles?

@ghost
Copy link
Author

ghost commented Apr 3, 2020

What does that mean?

@ilyasidorchik
Copy link
Owner

SCSS files, please.

@ilyasidorchik
Copy link
Owner

Could you not to repeat commit message? Reformat styles could be.

tsconfig.json Outdated Show resolved Hide resolved
.prettierrc Show resolved Hide resolved
src/pages/404.tsx Outdated Show resolved Hide resolved
@ilyasidorchik
Copy link
Owner

And you pushed master branch)

@ghost ghost requested a review from ilyasidorchik April 4, 2020 12:16
"plugins": ["stylelint-order"],
"rules": {
"max-line-length": 80,
"indentation": "tab",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"indentation": "tab",
"indentation": 2,

Comment on lines +5 to +6
"useTabs": true,
"tabWidth": 2,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"useTabs": true,
"tabWidth": 2,
"useTabs": false,

"extends": ["stylelint-config-prettier"],
"plugins": ["stylelint-order"],
"rules": {
"max-line-length": 80,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra margin needed.

Copy link
Owner

@ilyasidorchik ilyasidorchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see comments and reformat whole project again. Sorry for review delay and strange config mistake.

@github-staff github-staff deleted a comment Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant