Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving users control over min/maxIncluded for axis titles by including them into SideTitles (addresses #906) #1686

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sczesla
Copy link

@sczesla sczesla commented Jun 17, 2024

Including titles (labels) for the minimum and maximum data value is sometimes not desirable (see #906). The iterateThroughAxis routine (in axis_chart_helpers.dart) provides the logic for optional inclusion of the minimum and maximum already. This PR gives users control over these flags by incorporating them into SideTitles.

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 21, 2024

You haven't used the properties that you defined. I think you need to add them here.
Also, please read the contribution guideline carefully, you need to write unit-tests

@sczesla
Copy link
Author

sczesla commented Jun 25, 2024

Thanks for the feedback!

You haven't used the properties that you defined. I think you need to add them here.

I don't think so. Your link points to the defaults. The values are being used, possibly overwriting those defaults , when iterateThroughAxis is called here

Also, please read the contribution guideline carefully, you need to write unit-tests

Right. I added a test of the effect of setting the parameters when plotting, fixed formatting issues, edited the CHANGELOG, and rebased.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants