Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new access tokens url pattern #146

Closed
dabutvin opened this issue Aug 17, 2018 · 1 comment
Closed

Update to new access tokens url pattern #146

dabutvin opened this issue Aug 17, 2018 · 1 comment

Comments

@dabutvin
Copy link
Contributor

See https://developer.github.com/changes/2018-08-16-renaming-and-deprecation-of-github-app-installation-access-token-route/

@dabutvin
Copy link
Contributor Author

We've been using https://api.github.com/installations/:installation_id/access_tokens everywhere

now we need to update to https://api.github.com/app/installations/:installation_id/access_tokens

There are some places where we are reading and writing accessToken URL from the InstallationsTable. We should stop doing this altogether, it seemed like a good idea at the time, but we should just use the installationId and the access token pattern everywhere and stop reading and writing this data.

For example, we should remove these properties https://github.com/dabutvin/ImgBot/blob/8f893b3184a920bcf61e707c0df818a9089d1f7d/Common/Messages/CompressImagesMessage.cs#L5
https://github.com/dabutvin/ImgBot/blob/8f893b3184a920bcf61e707c0df818a9089d1f7d/Common/Messages/RouterMessage.cs#L9

dabutvin added a commit that referenced this issue Sep 6, 2018
snap to new access token pattern (fixes #146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant