Handle _Static_assert gracefully. Closes #276 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedataking
changed the title
ahomescu
reviewed
Jul 9, 2020
| @@ -857,6 +857,13 @@ class TranslateASTVisitor final | |||
| abort(); | |||
| } | |||
|
|
|||
| bool VisitStaticAssertDecl(StaticAssertDecl *SAD) { | |||
| std::vector<void *> childIds = {SAD->getAssertExpr(), SAD->getMessage()}; | |||
| auto T = QualType(); // don't care about the type | |||
There was a problem hiding this comment.
Does this need to be a separate variable?
There was a problem hiding this comment.
no, but if I just pass QualType() as the 4th argument how do I communicate that we don't care about this parameter?
There was a problem hiding this comment.
Move the comment to that line?
Co-authored-by: ahomescu <ah@immunant.com>
Co-authored-by: ahomescu <ah@immunant.com>
Co-authored-by: ahomescu <ah@immunant.com>
ahomescu
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, the c2rust transpiler barfs on translation units that use this feature. With it, we emit a warning instead.