Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stronghold_ext_storage for Es256 support #18

Merged
merged 17 commits into from
May 24, 2024

Conversation

nanderstabel
Copy link
Contributor

@nanderstabel nanderstabel commented May 21, 2024

Description of change

See title.

Links to any relevant issues

How the change has been tested

This change has been tested through UniMe and UniCore:

Disclaimer: for some reason some of the existing tests take over a minute to execute (successfully). I have a suspicion that this has something to do with the stronghold work factor but I have not been able to fix this. For this reason I have not yet added unit tests to prove that the added functionality works.
Interestingly, using this new and existing code in UniMe and UniCore does not seem to affect the performance.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel changed the title Feat/stronghold ext storage feat: stronghold ext storage May 21, 2024
@nanderstabel nanderstabel changed the base branch from dev to feat/es256-key-slot May 22, 2024 10:00
@nanderstabel nanderstabel changed the title feat: stronghold ext storage feat: add stronghold_ext_storage for Es256 support May 22, 2024
@nanderstabel nanderstabel self-assigned this May 22, 2024
@nanderstabel nanderstabel added the Addition A new feature that requires a minor release. label May 22, 2024
@nanderstabel nanderstabel marked this pull request as ready for review May 22, 2024 14:28
@daniel-mader daniel-mader merged commit 759dee7 into feat/es256-key-slot May 24, 2024
@daniel-mader daniel-mader deleted the feat/stronghold-ext-storage branch May 24, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Addition A new feature that requires a minor release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants