-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stronghold_ext_storage
for Es256
support
#18
Merged
daniel-mader
merged 17 commits into
feat/es256-key-slot
from
feat/stronghold-ext-storage
May 24, 2024
Merged
feat: add stronghold_ext_storage
for Es256
support
#18
daniel-mader
merged 17 commits into
feat/es256-key-slot
from
feat/stronghold-ext-storage
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
This was referenced May 21, 2024
6c0acd9
to
68c3248
Compare
stronghold_ext_storage
for Es256
support
dea79da
to
d4109ca
Compare
e933d37
to
943f36a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
See title.
Links to any relevant issues
How the change has been tested
This change has been tested through UniMe and UniCore:
ES256
identity-wallet#236ES256
ssi-agent#57Disclaimer: for some reason some of the existing tests take over a minute to execute (successfully). I have a suspicion that this has something to do with the stronghold work factor but I have not been able to fix this. For this reason I have not yet added unit tests to prove that the added functionality works.
Interestingly, using this new and existing code in UniMe and UniCore does not seem to affect the performance.
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.