Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Consolidate /badges and /credentials routes #366

Merged
merged 23 commits into from
Sep 17, 2024

Conversation

maiertech
Copy link
Member

@maiertech maiertech commented Sep 6, 2024

Description of change

  • I consolidated the /badges and /credentials routes into the /credenetials route.
    • The route gets a layout that includes the top navigation. This is the prototype for future layout refactorings.
    • I extracted components used on this route. This is WIP, as we will still need to come up with a better way to render individual claim fields.
    • On the new route, colors use semantic color names (see further down).
    • I updated the corresponding translations.
  • The root layout now manages safe area insets. The root layout also sets default semantic colors and can turn transparent for the /scan route.
  • I replaced .ttf fonts with standard web fonts in .woff2 format.
  • I introduced semantic color names and corresponding CSS variables which hold the correct color in light and dark mode. This reduces repetition and duplication to handle dark mode. In a future refactoring, more semantic colors should be introduced and applied to other routes.
  • I refactored the dark mode logic. Class dark is now applied to root layout.
  • I added @tailwindcss/typography to rendered Markdown prettier.
  • I fixed a number of z-index issues by adding additional stacking contexts.
  • I fixed the prerender settings for SvelteKit's adapter-static.

Links to any relevant issues

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@maiertech maiertech changed the title Maiertech/issue284 refactor: Consolidate badges and credentials routes and more Sep 6, 2024
@maiertech maiertech changed the title refactor: Consolidate badges and credentials routes and more refactor: Consolidate /badges and /credentials routes and more Sep 6, 2024
@maiertech maiertech marked this pull request as ready for review September 6, 2024 13:30
@maiertech maiertech self-assigned this Sep 6, 2024
unime/src/app.css Show resolved Hide resolved
unime/src/routes/+layout.svelte Outdated Show resolved Hide resolved
unime/src/routes/+layout.svelte Show resolved Hide resolved
unime/src/routes/credentials/[id]/+page.svelte Outdated Show resolved Hide resolved
unime/src/routes/welcome/+page.svelte Outdated Show resolved Hide resolved
unime/tailwind.config.js Outdated Show resolved Hide resolved
@daniel-mader daniel-mader changed the title refactor: Consolidate /badges and /credentials routes and more refactor: Consolidate /badges and /credentials routes Sep 16, 2024
@daniel-mader daniel-mader added Frontend This issue pertains to the UniMe frontend. Refactor Refactor code without changing functionality. labels Sep 17, 2024
@daniel-mader daniel-mader merged commit d9faf13 into dev Sep 17, 2024
3 checks passed
@daniel-mader daniel-mader deleted the maiertech/issue284 branch September 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend This issue pertains to the UniMe frontend. Refactor Refactor code without changing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate /badges and /credentialsroutes
2 participants