fix: Random blank pages for some NGDIL credentials #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Since the bug occurs during page rendering, I was unable to set a breakpoint and see what type of data is in a field when
startsWith
is invoked to check for a data URL. None of thecredentialSubjects
rendered with theDefaultRenderer
contain anything other thanstring
or something that can be coerced to a string.Therefore, it is not clear why the
DefaultRenderer
should not be able to callstartsWidth
. To be on the safe side, it now checks if the type is string before checking if a field is a data URL.Links to any relevant issues
How the change has been tested
Load the NGDIL credentials as described in #371 and test for every credential if it renders.
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.