Feat: support multiple did's and oid4vc-manager #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for RequestUrl Add missing request parameters Add sphereon demo website test Update documentation with new RequestUrl Remove sphereon demo example Add validate_request method to Provider struct Add preoper Ser and De for SiopRequest and RequestBuilder Add skeptic for Markdown code testing Add support for Request by reference fix: fix rebase conflicts Add comments and fix some tests fix: Move `derivative` to dev-dependencies Refactor Provider and Subject improve tests and example using wiremock Improve struct field serde fix: remove claims from lib.rs style: fix arguments order Add did:key DID method Add support for Request by reference fix: Remove lifetime annotations Add preoper Ser and De for SiopRequest and RequestBuilder Add Scope and Claim fix: fix rebase conflicts
Add tests for RequestUrl Add missing request parameters Add sphereon demo website test Update documentation with new RequestUrl Remove sphereon demo example Add validate_request method to Provider struct Add preoper Ser and De for SiopRequest and RequestBuilder Add skeptic for Markdown code testing Add support for Request by reference fix: fix rebase conflicts Add comments and fix some tests fix: Move `derivative` to dev-dependencies Refactor Provider and Subject improve tests and example using wiremock Improve struct field serde fix: remove claims from lib.rs style: fix arguments order Add did:key DID method Add support for Request by reference fix: Remove lifetime annotations Add preoper Ser and De for SiopRequest and RequestBuilder Add Scope and Claim fix: fix rebase conflicts
nanderstabel
force-pushed
the
feat/multi-did
branch
from
8133eeb
to
3829d30
Compare
nanderstabel
changed the title
nanderstabel
force-pushed
the
feat/multi-did
branch
from
0164c65
to
7e0efb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
RegistrationtoClientMetadatafollowing the 11th siopv2 spec adjustment: https://openid.bitbucket.io/connect/openid-connect-self-issued-v2-1_0.html#name-document-historyProviderandRelyingPartyto their respective "managers" inoid4vc-managercrate.did:keyanddid:iotato theoid4vc-managercrate. (the did iota method still has a slow unit test. This will be solved once we have the "mock" repo with different persona's.Subjectis the main trait which both the Provider and the RelyingParty will use. Subject has bothVerify(prev.Validator) andSignas trait bounds as well as theSyncandSendmarker traits. Strictly speaking a RelyingParty (as well as issuer) don't need to have aSubjectfor signing and verifying requests/responses. Therefore I already added theValidatorenum with variantsSubjectandVerifier.oid4vc-managercrate.Decoderstruct. This struct can be passed to bothRelyingPartyandProviderto validate either a response or a request. It uses it'sValidatorsto try to decode a givenjwt. The benefit of this implementation is that multiple Validator's can be used to verify a jwt that can be eitherSubjectorVerify.SubjectSyntaxTypesandDidMethodaccording to https://openid.bitbucket.io/connect/openid-connect-self-issued-v2-1_0.html#name-subject-syntax-typesLinks to any relevant issues
Closes #3
How the change has been tested
Bunch of unit-tests and one integration test in
oid4vc-managerDefinition of Done checklist
Add an
xto the boxes that are relevant to your changes.