-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Batch Credential Endpoint #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
changed the title
Feat/batch credential
feat: add Batch Credential Endpoint
Aug 5, 2023
nanderstabel
force-pushed
the
feat/batch-credential
branch
from
August 6, 2023 13:06
6be880e
to
645c095
Compare
nanderstabel
force-pushed
the
feat/batch-credential
branch
from
August 9, 2023 08:17
7f84870
to
0910e3f
Compare
daniel-mader
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Support for the OpenID4VCI Batch Credential : credential
Notable changes:
CredentialFormats
now needs a generic type (default isWithParameters
:This ensure that any datatype that has a
format
field, also includes a credentialformat-specific field(s). E.g. forjwt_vc_json
there need to be acredential_definition
field.However, in the (batch) credential response, instead of this additional credentialformat-specific field(s) there needs to be a
credential
field with a credentialformat-specific Credential. In this case the additional generic type forCredentialFormats
needs to beCredentialFormats<WithCredential>
. At the moment this type is still defaulted toserde_json::Value
for all credential formats, but this will change in the future.Links to any relevant issues
fixes #50
How the change has been tested
The Batch Credential Flow is tested in
oid4vc-manager/tests/oid4vci/pre_authorized_code.rs
.By using:
oid4vc-manager/tests/oid4vci/pre_authorized_code.rs
now test both single credential flow and batch credential flow.Serializing is tested in:
oid4vci/src/credential_response.rs
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.