-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Replay failing for some tests with Github #118
Comments
This sounds like a real issue, probably related to the one that's casuing request body truncation. I'll take a look at this and try to replicate. |
It looks like I'm getting similar results to @cfjedimaster while using it for same purpose (spiking out a service that receives Github webhook events). Mine doesn't seem to replay the request, either when on first try or otherwise. If it helps, I can post the data that GH is POSTing via the webhook 👍 |
Thanks, I'm pretty sure it's just the size of the request that's messing things up. Hopefully I should be able to deal with this soon. |
Cool, thank you @inconshreveable. I was just exposed to ngrok at work and within a few min had donated. It'll solve a number of development issues I've encountered while dev'ing things that need external facing routes (oauth, webhooks, etc). |
Same as issue #91. I'll have a fix out shortly, it's a bug in the Go standard library. |
Thanks for fixing this issue 👍 |
Ditto - thanks :) On Fri, Jun 6, 2014 at 12:50 PM, Zander Hill notifications@github.com
Raymond Camden, Web Developer for Adobe Email : raymondcamden@gmail.com |
Released and available for download |
I'm testing ngrok as a listener for Github webhook events. When I replay the first hit from Github, with this payload, it works fine:
However, I then tried to replay another one. I had my code logging to a file I'm tailing. I do not see an update in the log nor do I see an update in the ngrok UI. I get no response at all from the UI. I opened up Chrome Devtools and the event returned Ok, but it's definitely not running. This is the payload from the failing example.
(Hmm, the payload is large, posting a Gist instead.) https://gist.github.com/cfjedimaster/11148333
The text was updated successfully, but these errors were encountered: