Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Replay failing for some tests with Github #118

Closed
cfjedimaster opened this issue Apr 21, 2014 · 8 comments
Closed

Replay failing for some tests with Github #118

cfjedimaster opened this issue Apr 21, 2014 · 8 comments

Comments

@cfjedimaster
Copy link

I'm testing ngrok as a listener for Github webhook events. When I replay the first hit from Github, with this payload, it works fine:

["{\"zen\":\"It's not fully shipped until it's fast.\",\"hook_id\":2127743}"]

However, I then tried to replay another one. I had my code logging to a file I'm tailing. I do not see an update in the log nor do I see an update in the ngrok UI. I get no response at all from the UI. I opened up Chrome Devtools and the event returned Ok, but it's definitely not running. This is the payload from the failing example.

(Hmm, the payload is large, posting a Gist instead.) https://gist.github.com/cfjedimaster/11148333

@inconshreveable
Copy link
Owner

This sounds like a real issue, probably related to the one that's casuing request body truncation. I'll take a look at this and try to replicate.

@zph
Copy link

zph commented May 15, 2014

It looks like I'm getting similar results to @cfjedimaster while using it for same purpose (spiking out a service that receives Github webhook events).

Mine doesn't seem to replay the request, either when on first try or otherwise.

If it helps, I can post the data that GH is POSTing via the webhook 👍

@inconshreveable
Copy link
Owner

Thanks, I'm pretty sure it's just the size of the request that's messing things up. Hopefully I should be able to deal with this soon.

@zph
Copy link

zph commented May 15, 2014

Cool, thank you @inconshreveable.

I was just exposed to ngrok at work and within a few min had donated. It'll solve a number of development issues I've encountered while dev'ing things that need external facing routes (oauth, webhooks, etc).

@inconshreveable
Copy link
Owner

Same as issue #91. I'll have a fix out shortly, it's a bug in the Go standard library.

@zph
Copy link

zph commented Jun 6, 2014

Thanks for fixing this issue 👍

@cfjedimaster
Copy link
Author

Ditto - thanks :)

On Fri, Jun 6, 2014 at 12:50 PM, Zander Hill notifications@github.com
wrote:

Thanks for fixing this issue [image: 👍]


Reply to this email directly or view it on GitHub
#118 (comment)
.

Raymond Camden, Web Developer for Adobe

Email : raymondcamden@gmail.com
Blog : www.raymondcamden.com
Twitter: raymondcamden

@inconshreveable
Copy link
Owner

Released and available for download

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants