This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
client: add support for SHA-2 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inconshreveable
added a commit
that referenced
this pull request
Jun 12, 2014
client: add support for SHA-2
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the client to connect to a self-hosted
ngrokdthat's using a leaf or intermediate certificate with a SHA-2 hash aFailed to read message: remote error: bad certificateis received by the server.This is because SHA-2 isn't in
crypto/x509this PR remedies that.Further detail on this is here:
http://bridge.grumpy-troll.org/2014/05/golang-tls-comodo/
https://groups.google.com/forum/#!topic/Golang-nuts/hqm_ssUNUtI
I just had a certificate issued that triggers this issue - coincidentally a Comodo Positive SSL.