Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR1581 breaks demos and probably a lot of other things #1582

Closed
jhsware opened this issue Nov 13, 2021 · 2 comments
Closed

PR1581 breaks demos and probably a lot of other things #1582

jhsware opened this issue Nov 13, 2021 · 2 comments
Labels
bug

Comments

@jhsware
Copy link
Contributor

jhsware commented Nov 13, 2021 

const testingEnv = process.env.JEST_WORKER_ID !== undefined;

inferno/packages/inferno/src/index.ts

Line 24 in 5c017e1

const testingEnv = process.env.JEST_WORKER_ID !== undefined;

process isn't available in the browser. Also the solution is very implementation specific, should probably be solved in a more general way.

I suggest reverting this change and reopening the PR.
@Havunen
Copy link
Member

Havunen commented Nov 13, 2021

I will check this out later, its not publicly available yet

@Havunen Havunen added the bug label Nov 13, 2021
Havunen pushed a commit that referenced this issue Nov 16, 2021
Moved jest env check inside development branch and changed the expres…
2ed75dc 
…sion not to crash when part of it is not defined. Fixes Github #1582
@Havunen
Copy link
Member

Havunen commented Nov 16, 2021

fixed in master

@Havunen Havunen closed this as completed Nov 16, 2021
Havunen pushed a commit that referenced this issue Nov 16, 2021
Better fix for checking if process exists. Built new bundles Fixes Gi…
5b95578 
…thub #1582
@p1100i p1100i mentioned this issue Feb 2, 2024
Merged
Havunen pushed a commit that referenced this issue Feb 4, 2024
@p1100i
Rework development mode related inferno warnings #1573 #1582 (#1666)
e33158f 
* adds checking of variable `SKIP_INFERNO_WARNINGS` to skip warnings
  in non-production mode

* `SKIP_INFERNO_WARNINGS` can be also declared globally for browser
  functionality, or just defined on the process.env in case of node

* FYI: JEST related warning skip about development mode was removed
  with 2ed75dc when fixing #1582, only the skipping of
  minified code warning was in place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Havunen @jhsware