Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated .gitignore #397

Merged
merged 4 commits into from
Sep 25, 2016
Merged

Updated .gitignore #397

merged 4 commits into from
Sep 25, 2016

Conversation

nightwolfz
Copy link
Member

Ignore generates files since they don't belong in git

@LukeSheard
Copy link
Contributor

If we're going to ignore files in the dist directory then we should also remove them before we merge this.

@nightwolfz
Copy link
Member Author

@LukeSheard I was gonna make another PR for that if this one got approved

@Havunen
Copy link
Member

Havunen commented Sep 24, 2016

I like the idea of removing those files, but how will that affect our release process? Publishing to NPM and labeling builds in GIT?

@nightwolfz
Copy link
Member Author

nightwolfz commented Sep 24, 2016

How about adding a prepublish script to packages.json

"scripts": {
    ...
    "prepublish": "npm run clean && npm run build:prod"
  }

This will run automatically when executing npm publish

Ryan Megidov added 2 commits September 24, 2016 13:46
Add exception to .editorconfig because packages.json uses spaces at the moment
# Conflicts:
#	packages/inferno/dist/inferno-compat.js
#	packages/inferno/dist/inferno-compat.min.js
#	packages/inferno/dist/inferno-dom.js
#	packages/inferno/dist/inferno-dom.min.js
#	packages/inferno/dist/inferno-hyperscript.js
@nightwolfz nightwolfz merged commit b31661f into dev Sep 25, 2016
@LukeSheard LukeSheard deleted the dev-gitignore branch September 27, 2016 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants