Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDataString returns null, so get tag data from EXTRA_NDEF_MESSAGES #1

Merged
merged 3 commits into from
Dec 13, 2018

Conversation

sparkhead95
Copy link
Contributor

@sparkhead95 sparkhead95 commented Dec 12, 2018

Intent.getDataString() returns null so the user cannot see tag contents.
Instead get the tag data as a parcelable extra, and parse it that way. I've tested this on API 23 - 25 (works on both).
The min SDK can be reduced to 23 too.

Copy link
Owner

@infertux infertux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for some XML quirks.

.idea/modules.xml Outdated Show resolved Hide resolved
.idea/misc.xml Outdated Show resolved Hide resolved
@infertux infertux merged commit 9acdaa3 into infertux:master Dec 13, 2018
@infertux
Copy link
Owner

@sparkhead95 Good stuff, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants