ISPN-10224 Fix session fixation protection #6960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@thelateperseus I'm curious about what part of the maven build failed for you. |
|
@tristantarrant I had a lot of problems with our corporate proxy. Once I got past them, I got a failure on the Infinispan Core tests (I didn't specify |
|
Unfortunately there are 4-5 unstable tests (within over 25K tests). We are addressing these. The ideal way to test your changes is to do a full build with -DskipTests and then do a |
|
Thanks. I'll give that a try when I'm back in the office tomorrow. |
|
@tristantarrant I got an error about not being able to download a JAR when I ran
However, |
karesti
requested changes
May 29, 2019
| if (valueWrapper == null) { | ||
| return; | ||
| } | ||
| MapSession mapSession = (MapSession) valueWrapper.get(); | ||
| if (mapSession != null) { | ||
| applicationEventPublisher.emitSessionDeletedEvent(mapSession); |
There was a problem hiding this comment.
I'm not sure we need to send a session deleted event when the id has changed. I need to double check this behavior with spring session people.
There was a problem hiding this comment.
Grabbing a look to other code I know that we should not call deleteById but remove the entry from the repository using Infinispan remove and skip notifications. I will add a commit with the correction soon
karesti
requested changes
Jun 4, 2019
| if (valueWrapper == null) { | ||
| return; | ||
| } | ||
| MapSession mapSession = (MapSession) valueWrapper.get(); | ||
| if (mapSession != null) { | ||
| applicationEventPublisher.emitSessionDeletedEvent(mapSession); |
There was a problem hiding this comment.
Grabbing a look to other code I know that we should not call deleteById but remove the entry from the repository using Infinispan remove and skip notifications. I will add a commit with the correction soon
|
closing in favor of #7025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.infinispan.spring.common.session.AbstractInfinispanSessionRepositoryimplements thesave(MapSession)method defined byorg.springframework.session.SessionRepository. However, the implementation does not correctly handle when the session id changes. WhengetId()returns a different value fromgetOriginalId(), the original session should be deleted.Note that Spring Session's
MapSessionRepository.saveimplementation has the correct behaviour.I couldn't get the Maven build working, so I can't guarantee it compiles.
https://issues.jboss.org/browse/ISPN-10245
This issue was discovered by @the-cartographer has been assigned CVE-2019-10158.