Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oauth): add possibility to specify OAuthLogoutEndpoint for logout from OAuth Identity provider #6073

Merged
merged 5 commits into from
Feb 2, 2024

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jan 19, 2024

Related to https://github.com/influxdata/EAR/issues/4786

What was the problem?

The user remains logged in to the OAuth identity provider even after logging out from Chronograf. Therefore, during the next login to Chronograf, the user isn't prompted to enter credentials again.

What was the solution?

Chronograf now includes a new configuration property, OAuthLogoutEndpoint, which allows you to specify a logout callback. This callback is used to log out users from both Chronograf and their OAuth Identity Provider.

Customers will need to configure this property based on their respective identity providers. Below are the documentation links for a few common providers:

For instance, for a localhost instance of Chronograf using Auth0 as the provider, the configuration would look like this:

export OAUTH_LOGOUT_ENDPOINT=https://dev-xyz.us.auth0.com/v2/logout?returnTo=http://localhost:8080&client_id=abc

Copy link

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to compile all and to run updated tests locally. Changes to mux.go make sense.

@bednar bednar merged commit 08649d4 into master Feb 2, 2024
3 checks passed
@bednar bednar deleted the oauth-logout branch February 2, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants