Support cmake versions below 3.24.0 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/CMakeLists.txt to support cmake versions below 3.24
| @@ -7,7 +7,9 @@ set(CMAKE_CUDA_STANDARD_REQUIRED TRUE) | |||
| set(CMAKE_CXX_STANDARD_REQUIRED TRUE) | |||
| # add the target cuda architectures | |||
| # each additional architecture increases the compilation time and output file size | |||
| if (NOT DEFINED CMAKE_CUDA_ARCHITECTURES) | |||
| if (${CMAKE_VERSION} VERSION_LESS "3.24.0") | |||
| set(CMAKE_CUDA_ARCHITECTURES ${CUDA_ARCH}) | |||
There was a problem hiding this comment.
is it possible that CUDA_ARCH will be undefined ?
There was a problem hiding this comment.
Yes, it turns out that CUDA_ARCH is undefined. When line 11 runs, however, CMAKE_CUDA_ARCHITECTURES retains its original value. As such, perhaps a better way is:
if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.24.0")
set(CMAKE_CUDA_ARCHITECTURES native)
endif ()
There was a problem hiding this comment.
I think for now, this is good enough and I'll open an issue to ensure we made this robust
jeremyfelder
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
icicle/CMakeLists.txtto setCMAKE_CUDA_ARCHITECTURESto${CUDA_ARCH}if the cmake version is less than 3.24.0, andnativeotherwise. This change has been successfully tested with cmake 3.22.1 but I can't confirm if even earlier versions of cmake work.Linked Issues
Resolves #159. Thanks to @jeremyfelder for coming up with the solution!