Field creation automated through macros #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfelder
reviewed
Jul 4, 2024
jeremyfelder
reviewed
Jul 4, 2024
jeremyfelder
approved these changes
Jul 7, 2024
LeonHibnik
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Params files for fields now only require modulus specified by the user (also twiddle generator and/or non-residue in case either or both are needed). Everything else gets generated by a macro which seems to be much cleaner and easier than using python scripts / doing it by hand like it used to be before.
Future work
I also tried to do some general cleanup and minor perf improvements of primitives. Spent quite a bit of time trying to create correction-minimising formulas (sort of what Niall does here but for all fields and not just EC formula for a specific base field). This turned out to be much harder than expected and though I think I got it most of the way, the performance gains don't seem to justify the remaining effort considering significant increase in code complexity. If anyone is interested in this direction of work please let me know, I have an (almost) working prototype locally.
Most primitives related improvements I can think of are easier to do so if anything is particularly important to icicle right now, let me know. I can probably work on it in the background. Cheers.