Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/roman/hash docs #556

Merged
merged 15 commits into from
Jul 16, 2024
Merged

Feat/roman/hash docs #556

merged 15 commits into from
Jul 16, 2024

Conversation

ChickenLover
Copy link
Contributor

Describe the changes

This PR...

Linked Issues

Resolves #

Copy link
Collaborator

@jeremyfelder jeremyfelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left some small comments and grammar suggestions

docs/docs/icicle/primitives/poseidon.md Outdated Show resolved Hide resolved
docs/docs/icicle/primitives/keccak.md Show resolved Hide resolved
docs/docs/icicle/primitives/keccak.md Outdated Show resolved Hide resolved
docs/docs/icicle/primitives/poseidon2.md Outdated Show resolved Hide resolved
docs/docs/icicle/primitives/poseidon2.md Outdated Show resolved Hide resolved
docs/docs/icicle/primitives/poseidon2.md Outdated Show resolved Hide resolved
docs/docs/icicle/primitives/poseidon2.md Outdated Show resolved Hide resolved
docs/docs/icicle/primitives/poseidon2.md Outdated Show resolved Hide resolved
icicle/include/hash/keccak/keccak.cuh Outdated Show resolved Hide resolved
icicle/src/hash/keccak/extern.cu Outdated Show resolved Hide resolved
ChickenLover and others added 8 commits July 14, 2024 16:47
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
@LeonHibnik LeonHibnik merged commit a8fa05d into main Jul 16, 2024
27 checks passed
@LeonHibnik LeonHibnik deleted the feat/roman/hash-docs branch July 16, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants