fix: fix <noframes> parsing
#1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Sep 30, 2024
| expect(b.childNodes[0].nodeName).toBe('#text'); | ||
| expect((b.childNodes[0] as TextNode).value).toBe('should be outside'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I couldn't find a better place to put this test. For some reason the tests in test/data/html5lib-tests/serializer do not repro the issue.
nolanlawson
commented
Sep 30, 2024
| ['style'], | ||
| ['textarea'], | ||
| ['title'], | ||
| ['xmp'], |
There was a problem hiding this comment.
I tried to find all the "raw text" tags I knew of, based on the Firefox source code.
Again, all these tests were already passing except for noframes.
|
Thanks for this @nolanlawson! This also would be a good one to upstream to https://github.com/html5lib/html5lib-tests, which is used to the the majority of spec-compliant HTML parsers. |
wooorm
approved these changes
Sep 30, 2024
|
are we happy to merge this meanwhile? and open a separate issue to make sure we do add it to the upstream tests eventually |
|
@43081j Happy to do so |
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #972
This also adds a test to make sure that "raw text" tags (e.g.
<noembed>,<noframes>,<style>, etc.) all work the same. For the test, I'm reusing the same repro from #972.Before this fix, all the tests pass except for
<noframes>specifically.