Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tokenizer): Introduce events #404

Merged
merged 19 commits into from
Feb 27, 2022
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/parse5-html-rewriting-stream/lib/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Token, Location } from 'parse5/dist/common/token.js';
import type { Location } from 'parse5/dist/common/token.js';
import { SAXParser, EndTag, StartTag, Doctype, Text, Comment, SaxToken } from 'parse5-sax-parser';
import { escapeString } from 'parse5/dist/serializer/index.js';

Expand Down Expand Up @@ -73,9 +73,9 @@ export class RewritingStream extends SAXParser {
}

// Events
protected override _handleToken(token: Token): boolean {
if (!super._handleToken(token)) {
this.emitRaw(this._getRawHtml(token.location!));
protected override emitIfListenerExists(eventName: string, token: SaxToken): boolean {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SAX parser now handles events, so _handleToken is gone. We can override emitIfListenerExists instead for the same effect.

if (!super.emitIfListenerExists(eventName, token)) {
this.emitRaw(this._getRawHtml(token.sourceCodeLocation!));
}

// NOTE: don't skip new lines after <pre> and other tags,
Expand Down
186 changes: 96 additions & 90 deletions packages/parse5-sax-parser/lib/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import { Transform } from 'node:stream';
import { Tokenizer } from 'parse5/dist/tokenizer/index.js';
import { TokenType, Token, CharacterToken, Attribute, Location } from 'parse5/dist/common/token.js';
import type { Tokenizer, TokenHandler } from 'parse5/dist/tokenizer/index.js';
import type {
Attribute,
Location,
TagToken,
CommentToken,
DoctypeToken,
CharacterToken,
} from 'parse5/dist/common/token.js';
import { DevNullStream } from './dev-null-stream.js';
import { ParserFeedbackSimulator } from './parser-feedback-simulator.js';

Expand Down Expand Up @@ -39,13 +46,13 @@ export interface SAXParserOptions {
* });
* ```
*/
export class SAXParser extends Transform {
export class SAXParser extends Transform implements TokenHandler {
protected options: SAXParserOptions;
protected tokenizer: Tokenizer;
protected parserFeedbackSimulator: ParserFeedbackSimulator;
private pendingText: CharacterToken | null = null;
private pendingText: Text | null = null;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With _handleToken gone, we keep a Text object here for simplicity.

private lastChunkWritten = false;
private stopped = false;
protected tokenizer: Tokenizer;

/**
* @param options Parsing options.
Expand All @@ -58,8 +65,8 @@ export class SAXParser extends Transform {
...options,
};

this.tokenizer = new Tokenizer(this.options);
this.parserFeedbackSimulator = new ParserFeedbackSimulator(this.tokenizer);
this.parserFeedbackSimulator = new ParserFeedbackSimulator(this.options, this);
this.tokenizer = this.parserFeedbackSimulator.tokenizer;

// NOTE: always pipe stream to the /dev/null stream to avoid
// `highWaterMark` hit even if we don't have consumers.
Expand Down Expand Up @@ -127,96 +134,95 @@ export class SAXParser extends Transform {
}

private _runParsingLoop(): void {
let token = null;
while (!this.stopped && this.tokenizer.active) {
this.tokenizer.getNextToken();
}
}

do {
token = this.parserFeedbackSimulator.getNextToken();
/** @internal */
onCharacter({ chars, location }: CharacterToken): void {
if (this.pendingText === null) {
this.pendingText = { text: chars, sourceCodeLocation: location };
} else {
this.pendingText.text += chars;

if (token.type === TokenType.HIBERNATION) {
break;
if (location && this.pendingText.sourceCodeLocation) {
const { endLine, endCol, endOffset } = location;
this.pendingText.sourceCodeLocation = {
...this.pendingText.sourceCodeLocation,
endLine,
endCol,
endOffset,
};
}
}
}

if (
token.type === TokenType.CHARACTER ||
token.type === TokenType.WHITESPACE_CHARACTER ||
token.type === TokenType.NULL_CHARACTER
) {
if (this.pendingText === null) {
token.type = TokenType.CHARACTER;
this.pendingText = token;
} else {
this.pendingText.chars += token.chars;

if (token.location && this.pendingText.location) {
const { endLine, endCol, endOffset } = token.location;
this.pendingText.location = {
...this.pendingText.location,
endLine,
endCol,
endOffset,
};
}
}
} else {
this._emitPendingText();
this._handleToken(token);
}
} while (!this.stopped && token.type !== TokenType.EOF);
/** @internal */
onWhitespaceCharacter(token: CharacterToken): void {
this.onCharacter(token);
}

protected _handleToken(token: Token): boolean {
switch (token.type) {
case TokenType.EOF: {
return true;
}
case TokenType.START_TAG: {
const startTag: StartTag = {
tagName: token.tagName,
attrs: token.attrs,
selfClosing: token.selfClosing,
sourceCodeLocation: token.location,
};
return this._emitIfListenerExists('startTag', startTag);
}
case TokenType.END_TAG: {
const endTag: EndTag = {
tagName: token.tagName,
sourceCodeLocation: token.location,
};
return this._emitIfListenerExists('endTag', endTag);
}
case TokenType.COMMENT: {
const comment: Comment = {
text: token.data,
sourceCodeLocation: token.location,
};
return this._emitIfListenerExists('comment', comment);
}
case TokenType.DOCTYPE: {
const doctype: Doctype = {
name: token.name,
publicId: token.publicId,
systemId: token.systemId,
sourceCodeLocation: token.location,
};
return this._emitIfListenerExists('doctype', doctype);
}
case TokenType.CHARACTER:
case TokenType.NULL_CHARACTER:
case TokenType.WHITESPACE_CHARACTER: {
const text: Text = {
text: token.chars,
sourceCodeLocation: token.location,
};
return this._emitIfListenerExists('text', text);
}
case TokenType.HIBERNATION: {
return this._emitIfListenerExists('hibernation', {});
}
}
/** @internal */
onNullCharacter(token: CharacterToken): void {
this.onCharacter(token);
}

/** @internal */
onEof(): void {
this._emitPendingText();
this.stopped = true;
}

/** @internal */
onStartTag(token: TagToken): void {
this._emitPendingText();

const startTag: StartTag = {
tagName: token.tagName,
attrs: token.attrs,
selfClosing: token.selfClosing,
sourceCodeLocation: token.location,
};
this.emitIfListenerExists('startTag', startTag);
}

/** @internal */
onEndTag(token: TagToken): void {
this._emitPendingText();

const endTag: EndTag = {
tagName: token.tagName,
sourceCodeLocation: token.location,
};
this.emitIfListenerExists('endTag', endTag);
}

/** @internal */
onDoctype(token: DoctypeToken): void {
this._emitPendingText();

const doctype: Doctype = {
name: token.name,
publicId: token.publicId,
systemId: token.systemId,
sourceCodeLocation: token.location,
};
this.emitIfListenerExists('doctype', doctype);
}

/** @internal */
onComment(token: CommentToken): void {
this._emitPendingText();

const comment: Comment = {
text: token.data,
sourceCodeLocation: token.location,
};
this.emitIfListenerExists('comment', comment);
}

private _emitIfListenerExists(eventName: string, token: SaxToken): boolean {
protected emitIfListenerExists(eventName: string, token: SaxToken): boolean {
if (this.listenerCount(eventName) === 0) {
return false;
}
Expand All @@ -232,7 +238,7 @@ export class SAXParser extends Transform {

private _emitPendingText(): void {
if (this.pendingText !== null) {
this._handleToken(this.pendingText);
this.emitIfListenerExists('text', this.pendingText);
this.pendingText = null;
}
}
Expand Down
Loading