Puppet 4, module data, and mangle support #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the module to support puppet 4, including a transition from `Modulefile` to `metadata.json`, fixups of file and concat mode specification, and reworking of fact references. Get rid of the `shorewall_version` fact and instead of using conditional statements around this fact to select behaviors in the manifests, use hiera in the form of module data. I think I've got the values set up correctly for different LTS versions of Ubuntu and released versions of Debian, but no guarantees. Finally, create more explicit support for mangle rules, and rework the mark define as a special case of it.
Avoid clobbering the entire defaults file with augeas. Really just want to tell shorewall it's ok to start up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the module to support puppet 4, including a transition from
Modulefileto
metadata.json, fixups of file and concat mode specification, and reworkingof fact references.
Get rid of the
shorewall_versionfact and instead of using conditionalstatements around this fact to select behaviors in the manifests, use hiera in
the form of module data. I think I've got the values set up correctly for
different LTS versions of Ubuntu and released versions of Debian, but no
guarantees.
Finally, create more explicit support for mangle rules, and rework the mark
define as a special case of it.