Add failed state and test second deploy #8090
Conversation
src/inmanta/deploy/work.py
Outdated
|
|
||
| from inmanta.data.model import ResourceIdStr | ||
| from inmanta.resources import Id | ||
|
|
||
|
|
||
| @dataclass(frozen=True, kw_only=True) | ||
| class _Task(abc.ABC): | ||
| class Task(abc.ABC): |
There was a problem hiding this comment.
Why still define the ABC here? I think it would make sense to move it to tasks as well, so that work depends on tasks but not vice versa.
There was a problem hiding this comment.
right, that could make things better
I found it more natural to have the abstract in one place, but I see the point
src/inmanta/deploy/tasks.py
Outdated
| pass | ||
|
|
||
|
|
||
| class WithHashMatchTask(work.Task): |
There was a problem hiding this comment.
Where does this name come from? i.e. how does RefreshFact care about hash matching? From the implementation I see only the fact that they act on the latest version.
There was a problem hiding this comment.
It may not be the best name, but given the plan to eliminate it, I would not invest too much time in it
There was a problem hiding this comment.
the plan to eliminate it
Do you mean given my proposal on Slack? I'm not sure it would go in its entirety but we'll see.
| """Construct an agent that can execute using the resource container""" | ||
| agentmanager = server.get_slice(SLICE_AGENT_MANAGER) | ||
|
|
||
| # First part - test the ResourceScheduler (retrieval of data from DB) |
There was a problem hiding this comment.
Did this comment get lost? It doesn't seem to apply here.
Co-authored-by: Sander Van Balen <git@sandervanbalen.be>
…ta-core into issue/testing_all_features
|
Processing this pull request |
|
Merged into branches master in 9ed614e |
# Description Basic end-to-end testing close #8010 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [X] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Description
Basic end-to-end testing
close #8010
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box