Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for using with React #171

Merged
merged 2 commits into from
Jun 17, 2017
Merged

Conversation

glennreyes
Copy link
Contributor

No description provided.

@inorganik
Copy link
Owner

Nice work. It would have been nice if this was part of the same repo (like the angular wrapper is), but with all the react dependencies in package.json I can see why it needed to be separate.

One request, I know this is nit-picky, but can you put the React stuff after Angular 2, in each section? That way it is linked in the order it was added. Then I'll merge. Thanks.

@glennreyes
Copy link
Contributor Author

glennreyes commented Jun 17, 2017

It would have been nice if this was part of the same repo (like the angular wrapper is), but with all the react dependencies in package.json I can see why it needed to be separate.

Exactly, also react-countup wouldn't work without countup.js as a dependency.

One request, I know this is nit-picky, but can you put the React stuff after Angular 2, in each section? That way it is linked in the order it was added.

Sure!

@inorganik inorganik merged commit 7934889 into inorganik:master Jun 17, 2017
@inorganik
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants