Patch 1 #199
Merged
Patch 1 #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original width of 15px seemed to narrow if a user wanted to add "years old" as a suffix.
|
Just FYI, prefix/suffix are meant for 1-2 character strings that get attached on either side of the number. For longer strings you should do: <h1>So and so is <span id="countUpTarget"></span> years old</h1>Either way is valid. |
|
OK, thanks for the tip, I hadn't thought about doing it that way. This was my first time contributing to open source repo so still lots to learn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a...
Checklist
Description
_The original width of 15px seemed to narrow if a user wanted to add "years old" as a suffix.
Does this PR introduce a breaking change?