Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: hide seekbar patch hides the seekbar color at the bottom of every video when the user view the list of watch history #1013

Closed
5 tasks done
BrilliantlyEducated opened this issue May 12, 2023 · 6 comments
Labels
Bug report Something isn't working

Comments

@BrilliantlyEducated
Copy link

BrilliantlyEducated commented May 12, 2023

Type

Error at runtime

Tools used

Revancify

Application

YouTube v18.17.43

Bug description

it hides the seekbar color under the videos

Steps to reproduce

step 1. turn on hide seekbar
step 2. go to watch history

Relevant log output

.

Screenshots or videos

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • I have written the title and contents in English.
  • This issue does not reproduce on unpatched YouTube or YT Music.
@BrilliantlyEducated BrilliantlyEducated added the Bug report Something isn't working label May 12, 2023
@BrilliantlyEducated BrilliantlyEducated changed the title bug: hiding seekbar hides seekbar color from the watch history page bug: hiding seekbar also hides seekbar color from the watch history page May 12, 2023
@inotia00
Copy link
Owner

inotia00 commented May 12, 2023

I misunderstood the content of the issue
Issue is reproducible

This seems to be the intended part, so I won't fix it.

instead, I will edit the description of the hide seek bar patch later.

@BrilliantlyEducated
Copy link
Author

I misunderstood the content of the issue Issue is reproducible

This seems to be the intended part, so I won't fix it.

instead, I will edit the description of the hide seek bar patch later.

this is what i meant
example(1)

example(2)

it should be like this
example(3)

@inotia00
Copy link
Owner

Yeah I understood that, but no plans to fix it

Instead, I would edit the description of Hide seekbar like this:
Hides the seekbar and the progress bar

@BrilliantlyEducated BrilliantlyEducated changed the title bug: hiding seekbar also hides seekbar color from the watch history page bug: hide seekbar patch hides the seekbar color at the bottom of every video when the user view the list of watch history May 13, 2023
@BrilliantlyEducated
Copy link
Author

BrilliantlyEducated commented May 13, 2023

Yeah I understood that, but no plans to fix it

Instead, I would edit the description of Hide seekbar like this: Hides the seekbar and the progress bar

this only happens in revanced-patches v2.173.8 i don't know about v2.173.6 but maybe yeah maybe nah

unanswered issues:

#844

#586

@inotia00
Copy link
Owner

chanelog

That's the change in revanced-patches-v2.173.6

This is the result of applying the source code in the official ReVanced dev branch.
(intended part)

Users no longer have to change the progress bar color via options.json

Also, if you change hide seekbar to on, the progress bar is also hidden.

@inotia00
Copy link
Owner

Also, I checked all patch-requests

patch-requests that are difficult to implement with current methods do not leave comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants