Merge pull request #1852 from input-output-hk/jpraynaud/1836-fix-chai…

…n-reader-stuck-error fix: `ChainReader` fails on `find_intersect_point` without agency
input-output-hk · Jul 24, 2024 · 3b6557b · 3b6557b
2 parents 0e21965 + 8f88564
commit 3b6557b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,8 @@ As a minor extension, we have adopted a slightly different versioning convention
 
 - `mithril-aggregator` node produces artifact for different signed entity types in parallel.
 
+- Fix `Agency is theirs` error in the `ChainReader` when the underlying `Chain sync` client does not have agency.
+
 - **UNSTABLE** Cardano transactions certification:
 
   - Make Cardano transaction signing settings configurable via the CD.

diff --git a/mithril-common/src/chain_reader/pallas_chain_reader.rs b/mithril-common/src/chain_reader/pallas_chain_reader.rs
@@ -54,9 +54,11 @@ impl PallasChainReader {
         let client = self.get_client().await?;
         let chainsync = client.chainsync();
 
-        chainsync
-            .find_intersect(vec![point.to_owned().into()])
-            .await?;
+        if chainsync.has_agency() {
+            chainsync
+                .find_intersect(vec![point.to_owned().into()])
+                .await?;
+        }
 
         Ok(())
     }
@@ -327,6 +329,19 @@ mod tests {
             let client = chain_reader.get_client().await.unwrap();
             client.chainsync().request_next().await.unwrap();
 
+            // make sure that the chainsync client returns an error when attempting to find intersection without agency
+            client
+                .chainsync()
+                .find_intersect(vec![known_point.clone()])
+                .await
+                .expect_err("chainsync find_intersect without agency should fail");
+
+            // make sure that setting the chain point is harmless when the chainsync client does not have agency
+            chain_reader
+                .set_chain_point(&ChainPoint::from(known_point.clone()))
+                .await
+                .unwrap();
+
             chain_reader.get_next_chain_block().await.unwrap().unwrap()
         });
 

diff --git a/mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs b/mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs
@@ -89,7 +89,7 @@ impl Aggregator {
             ("CARDANO_TRANSACTIONS_DATABASE_CONNECTION_POOL_SIZE", "5"),
             (
                 "CARDANO_TRANSACTIONS_SIGNING_CONFIG__SECURITY_PARAMETER",
-                "15",
+                "1",
             ),
             ("CARDANO_TRANSACTIONS_SIGNING_CONFIG__STEP", "15"),
         ]);