Remove task::block_in_place in transaction importer
#1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
djo/remove_block_in_place
branch
from
0774128
to
2f9843d
Compare
jpraynaud
approved these changes
Jul 11, 2024
… importers This avoid issues with `block_in_place` such as suspension of code running concurrently in the same task (see: <https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html>). It also avoid the need of specifying `(flavor = "multi_thread")` for the tests.
* Mithril-aggregator from `0.5.41` to `0.5.42` * Mithril-signer from `0.2.163` to `0.2.164`
Alenar
force-pushed
the
djo/remove_block_in_place
branch
from
2f9843d
to
252f549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a small refactor of aggregator & signer
CardanoTransactionImporterthreading logic to use task::spawn_blocking instead of task::block_in_place.Pre-submit checklist