Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Signer make test command errors #1817

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Fix Signer make test command errors #1817

merged 2 commits into from
Jul 12, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jul 12, 2024 •
edited
Loading

Content

This PR includes modifications in the aggregator_client tests of the mithril-signer.
MockServer passed as a parameter was being consumed, leading to errors in the tests.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1816

@dlachaume dlachaume self-assigned this Jul 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   8m 57s ⏱️ -1s
1 145 tests ±0  1 145 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 311 runs  ±0  1 311 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6eb2214. ± Comparison against base commit 7c0ca2b.

♻️ This comment has been updated with latest results.

jpraynaud
jpraynaud approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dlachaume and others added 2 commits July 12, 2024 11:31
@dlachaume @sfauvel
Remove ownership on MockServer in aggregator_client test functions
25b20e7 
Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
@dlachaume
Update crate version
6eb2214
@dlachaume dlachaume force-pushed the ensemble/1816/fix-signer-test-functions-aggregator-client branch from 9d0b21d to 6eb2214 Compare July 12, 2024 09:31
sfauvel
sfauvel approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume merged commit 45ca0e0 into main Jul 12, 2024
41 checks passed
@dlachaume dlachaume deleted the ensemble/1816/fix-signer-test-functions-aggregator-client branch July 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Awaiting requested review from Alenar

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signer make test command fails
3 participants
@dlachaume @sfauvel @jpraynaud