Fix: Explorer keep previous error until refresh in cardano transaction certification modal #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versioss 9 and up of `eslint` are not compatible with versions 14.2+ of `eslint-config-next`. This fix the version of `esling` to the last compatible: `^8.57.0` for the time being. It should be reworked to `latest` when the incompatiblity is fixed.
…ertification modal This was simply due to the error not being set to its default state when opening the modal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR fix #1818: when an error was catch by the Cardano transaction certification modal it was never reset so it would reappear even if the certification was successful, only a refresh would reset it.
This solve this problem by resetting the error to its default state each time the modal is opened.
Pre-submit checklist
Comments
This PR also do a temporary fix to the
make upgradeof the explorer: since it was crashing because of incompatibility between two dependency it fix one of those dependency to a working version (until the problem is solved by those third party then we will go back to the previous behavior of updating to the latest version available).Issue(s)
Closes #1818