Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics table in the "Activate Prometheus endpoint" section #1833

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Add metrics table in the "Activate Prometheus endpoint" section #1833

merged 3 commits into from
Jul 16, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jul 16, 2024 •
edited
Loading

Content

Add metrics table in the "Activate Prometheus endpoint" section of the "Run a Mithril signer as an SPO" guide.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1834

@dlachaume dlachaume self-assigned this Jul 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   8m 54s ⏱️ -9s
1 153 tests ±0  1 153 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 319 runs  ±0  1 319 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a0d068f. ± Comparison against base commit 2d04e58.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume marked this pull request as draft July 16, 2024 09:53
@dlachaume dlachaume force-pushed the dlachaume/update-activate-prometheus-endpoint-doc branch 2 times, most recently from c9e5469 to 886c532 Compare July 16, 2024 09:59
@dlachaume dlachaume force-pushed the dlachaume/update-activate-prometheus-endpoint-doc branch from 886c532 to 78591ea Compare July 16, 2024 10:17
@dlachaume dlachaume marked this pull request as ready for review July 16, 2024 10:27
@dlachaume dlachaume force-pushed the dlachaume/update-activate-prometheus-endpoint-doc branch from 78591ea to 7075c1d Compare July 16, 2024 10:30
@dlachaume dlachaume force-pushed the dlachaume/update-activate-prometheus-endpoint-doc branch from 7075c1d to a0d068f Compare July 16, 2024 13:20
@dlachaume dlachaume merged commit 4bc87f0 into main Jul 16, 2024
40 checks passed
@dlachaume dlachaume deleted the dlachaume/update-activate-prometheus-endpoint-doc branch July 16, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Awaiting requested review from Alenar

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document Prometheus metrics and Grafana Dahsboard for signer
3 participants
@dlachaume @sfauvel @jpraynaud