Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensemble/1825/cleanup immutable file in cardano transation #1838

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Ensemble/1825/cleanup immutable file in cardano transation #1838

merged 9 commits into from
Jul 17, 2024

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Jul 17, 2024 •
edited
Loading

Content

This PR removes all references to immutable_file in Cardano Transaction signed entity processing.

  • remove immutable_file_number column from cardano_tx.
  • remove immutable_file_number field from type entities::CardanoTransaction and ScannedBlock.
  • remove ImmutableBlockStreamer and CardanoImmutableBlockScanner.
  • simplify BlockScanner trait by removing the dirpath parameter of the scan method. That allow to remove it from CardanoTransactionsImporter service.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1825

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Test Results

    4 files  ± 0     52 suites  ±0   8m 51s ⏱️ -11s
1 138 tests  - 15  1 138 ✅  - 15  0 💤 ±0  0 ❌ ±0 
1 304 runs   - 15  1 304 ✅  - 15  0 💤 ±0  0 ❌ ±0 

Results for commit ca91a6d. ± Comparison against base commit ba32347.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-sanchonet July 17, 2024 13:19 — with GitHub Actions Inactive
@sfauvel sfauvel marked this pull request as ready for review July 17, 2024 13:24
@sfauvel sfauvel temporarily deployed to testing-sanchonet July 17, 2024 13:31 — with GitHub Actions Inactive
@sfauvel sfauvel requested review from Alenar, dlachaume and jpraynaud and removed request for dlachaume July 17, 2024 13:40
jpraynaud
jpraynaud approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfauvel
Upgrade crates versions
ca91a6d 
* Mithril-signer: 0.2.166 => 0.2.167
* Mithril-persistence: 0.2.17 => 0.2.18
* Mithril-common: 0.4.31 => 0.4.32
* Mithril-aggregator: 0.5.44 => 0.5.45
@sfauvel sfauvel force-pushed the ensemble/1825/cleanup_immutable_file_in_cardano_transation branch from fbdb299 to ca91a6d Compare July 17, 2024 15:02
@sfauvel sfauvel temporarily deployed to testing-sanchonet July 17, 2024 15:09 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 1375bce into main Jul 17, 2024
40 checks passed
@sfauvel sfauvel deleted the ensemble/1825/cleanup_immutable_file_in_cardano_transation branch July 17, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup Immutable File in Cardano transaction
4 participants
@sfauvel @Alenar @jpraynaud @dlachaume