Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deprecated beacon field optional in Certificate & CertificateList messages #1839

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Make deprecated beacon field optional in Certificate & CertificateList messages #1839

merged 5 commits into from
Jul 18, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Jul 17, 2024 •
edited
Loading

Content

This PR make the, deprecated, beacon field an Option in the Certificate & CertificateList messages.

This will allow us to remove them completely in the future when enough nodes have been updated, making the switch to "variable" beacon, aka SignedEntityType, complete.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1807

@Alenar @sfauvel
Fix invalid source for metadata.network when converting certificate m…
97a75de 
…essage to entity

It used the deprecated beacon instead of using the
`CertificateMetadataMessagePart` network field that's the updated,
long-term, field to use.

Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
Alenar and others added 2 commits July 17, 2024 17:25
@Alenar @sfauvel
Make beacon optional in CertificateMessage
6c5d517 
So we can remove it gracefully in the future when enough nodes have
updated.

Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
@Alenar @sfauvel
Make beacon optional in CertificateListMessage
b3b5ae1 
So we can remove it gracefully in the future when enough nodes have
updated.

Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
@Alenar Alenar force-pushed the ensemble/1807/optional_beacon_in_cert_messages branch from 25ca517 to 61e1ba0 Compare July 17, 2024 15:26
@Alenar @sfauvel
Make beacon optional for Certificate & CertificateList in openapi
2f895b5 
Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
@Alenar Alenar force-pushed the ensemble/1807/optional_beacon_in_cert_messages branch 2 times, most recently from cd52839 to 10c1600 Compare July 17, 2024 15:33
@Alenar
Upgrade crates & open api versions
3be9550 
* Mithril-aggregator from `0.5.45` to `0.5.46`
* Mithril-client-cli from `0.9.6` to `0.9.7`
* Mithril-common from `0.4.32` to `0.4.33`
* OpenApi from `0.1.26` to `0.1.27`
@Alenar Alenar force-pushed the ensemble/1807/optional_beacon_in_cert_messages branch from 10c1600 to 3be9550 Compare July 17, 2024 15:38
@github-actions GitHub Actions
Copy link

Test Results

    4 files  ±0     52 suites  ±0   9m 2s ⏱️ -1s
1 142 tests +4  1 142 ✅ +4  0 💤 ±0  0 ❌ ±0 
1 308 runs  +4  1 308 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 3be9550. ± Comparison against base commit 1375bce.

This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both. 
mithril-common ‑ messages::certificate::tests::test_v1
mithril-common ‑ messages::certificate_list::tests::test_v1

mithril-common ‑ messages::certificate::tests::test_actual_json_deserialized_into_actual_message
mithril-common ‑ messages::certificate::tests::test_actual_json_deserialized_into_previous_message
mithril-common ‑ messages::certificate::tests::test_json_next_version_deserialized_into_actual_message
mithril-common ‑ messages::certificate_list::tests::test_actual_json_deserialized_into_actual_message
mithril-common ‑ messages::certificate_list::tests::test_actual_json_deserialized_into_previous_message
mithril-common ‑ messages::certificate_list::tests::test_json_next_version_deserialized_into_actual_message

@Alenar Alenar temporarily deployed to testing-sanchonet July 17, 2024 15:59 — with GitHub Actions Inactive
dlachaume
dlachaume approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jpraynaud
jpraynaud approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alenar Alenar merged commit a2d3fe1 into main Jul 18, 2024
43 checks passed
@Alenar Alenar deleted the ensemble/1807/optional_beacon_in_cert_messages branch July 18, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Certificate messages beacon field optional
4 participants
@Alenar @sfauvel @jpraynaud @dlachaume