This repository has been archived by the owner on Jun 11, 2022. It is now read-only.
Improve trait bounds on blockchain entities #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 13, 2019 21:48
It's good for Deserialize::Error to satisfy Send + Sync + 'static, as it can then be boxed into higher level errors. For objects passed from strings, we need to impose the similar bounds on the error type of standard trait FromStr. To this end, define a property trait FromStr, blanket-implemented with the new bounds.
Use utility traits defined in module chain_bounds to centralize bounds on the chain types necessary for the client implementation.
NicolasDP
reviewed
Feb 13, 2019
| fn from_str(s: &str) -> Result<Self, Self::Error> { | ||
| std::str::FromStr::from_str(s) | ||
| } | ||
| } |
There was a problem hiding this comment.
argh... this is very hacky... :/
There was a problem hiding this comment.
rust-lang/rust#32722 does not allow just adding a subtrait with extra bounds on FromStr::Err.
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
+ Coverage 47.62% 47.79% +0.17%
==========================================
Files 123 124 +1
Lines 12108 12151 +43
==========================================
+ Hits 5766 5808 +42
- Misses 6342 6343 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
chain-coreproperty traitFromStrto impose extra requirements on parsing values such as block dates from strings.Require the error types for deserialization and string parsing to be safe for passing between threads, so that they can be boxed and contained in e.g.
client::Errorofnetwork-core.Trait work in gRPC client code to reduce repetitive bound clauses.