Compartmentalize gojsonschema Format types #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garethr I couldn't actually confirm that these FormatCheckers are still required. Could you verify? If they need to be updated, I'll gladly take a look into doing so. |
|
Looks like this needs rebasing against master now with the PR's I've just merged. Unfortunately I think those are still required in some cases, if memory serves they dealt with issues/differences between OpenAPI and JSONSchema. I'll try and write a test case. |
ian-howell
force-pushed
the
clean/relocate-formats
branch
from
3f38f36
to
11ba817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the ValidFormat type and its related functions out of the
main package code. It also moves the calls to FormatCheckers.Add to an
init function so as to only call them once per application run.