Skip to content

Commit

Permalink
Fixes #546 (#551)
Browse files Browse the repository at this point in the history
* Fixes #546

* Update STREAM RFC to clarify how `ConnectionAssetDetails` are communicated for a given STREAM Connection.
* Clarify the relationship between `ConnectionAssetDetails` and `ConnectionNewAddress `.

Signed-off-by: sappenin <sappenin@gmail.com>

* Update 0029-stream/0029-stream.md

Co-Authored-By: Kincaid O'Neil <kincaidoneil@users.noreply.github.com>

* Update per PR comments.

Signed-off-by: sappenin <sappenin@gmail.com>

* Remove redundant clarification.

Signed-off-by: sappenin <sappenin@gmail.com>

* Remove wordy sentence

Signed-off-by: sappenin <sappenin@gmail.com>

* Remove language about ignoring subsequent frames.

Signed-off-by: sappenin <sappenin@gmail.com>

* Removing breaking proposed changes.

Signed-off-by: sappenin <sappenin@gmail.com>

* Remove whitespace

Signed-off-by: sappenin <sappenin@gmail.com>

* Remove inaccurate example.

Signed-off-by: sappenin <sappenin@gmail.com>

* Bumping draft number to test the build scripts

Signed-off-by: sappenin <sappenin@gmail.com>

* Reducing the draft num

Signed-off-by: sappenin <sappenin@gmail.com>

* Restoring correct draft number

Signed-off-by: sappenin <sappenin@gmail.com>

* Skip Version Check

Skip Version Check

Signed-off-by: sappenin <sappenin@gmail.com>
  • Loading branch information
sappenin authored and adrianhopebailie committed Oct 23, 2019
1 parent 7071dc7 commit 734c2f0
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions 0029-stream/0029-stream.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: STREAM - A Multiplexed Money and Data Transport for ILP
draft: 7
draft: 8
---

# STREAM: A Multiplexed Money and Data Transport for ILP
Expand Down Expand Up @@ -174,7 +174,9 @@ Implementations SHOULD wait for a valid response (encrypted with the same shared

#### 4.3.1. Connection Asset Details

Each endpoint MAY expose their asset details by sending a `ConnectionAssetDetails` frame.
Each endpoint MAY expose their asset details by sending a `ConnectionAssetDetails` frame. This frame is optional because some use-cases do not require it.

Asset details exposed by this frame MUST not change during the lifetime of a Connection.

### 4.4. Streams

Expand Down Expand Up @@ -432,6 +434,8 @@ In other words, if a sender resends data (e.g. because a packet was lost), it MU
| Source Asset Code | Utf8String | Asset code of endpoint that sent the frame. |
| Source Asset Scale | UInt8 | Asset scale of endpoint that sent the frame. |

Asset details exposed by this frame MUST NOT change during the lifetime of a Connection.

### 5.4. Error Codes

Error codes are sent in `StreamClose` and `ConnectionClose` frames to indicate what caused the stream or connection to be closed.
Expand Down

0 comments on commit 734c2f0

Please sign in to comment.