-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
df/add-stream-test-vectors #555
Conversation
Introduces a JSON file that allows STREAM implementations to validate their ASN.1 OER encoding/decoding of alll Frames defined in IL-RFC-29. Signed-off-by: sappenin <sappenin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this should test whole packets (with encryption) as well as the inner frames
Good call - I'll update that today and tag you when it's ready. |
@sappenin consider using part or all of https://github.com/interledgerjs/ilp-protocol-stream/blob/master/test/fixtures/packets.json (generated by https://github.com/interledgerjs/ilp-protocol-stream/blob/master/scripts/generate-fixtures.ts). It might be excessive, but it does cover some important gotchas around e.g. exceeding max uint64s (https://github.com/interledgerjs/ilp-protocol-stream/blob/master/test/fixtures/packets.json#L810-L846). |
@sentientwaffle Wow, that test harness is much better than the one I created. I see there's a generator, so is it correct to say that we can just take the |
@sappenin Thanks! The generator is just for convenience -- to make it easier to add additional test cases. Adding the |
@sentientwaffle Sounds good - one question about the |
Remove `frame:connection_new_address:empty` test (per interledger/rfcs#555 (comment)).
You're correct, an empty address should be invalid. Not sure what I was thinking when I added that test case. |
Signed-off-by: sappenin <sappenin@gmail.com>
@sentientwaffle I just pushed new changes to this PR that mirror your test vectors. Want to give this another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes, but overall LGTM.
Signed-off-by: sappenin <sappenin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm not sure why circleci believes so many files changed (causing it to fail).
…am-frame-test-vectors
Remove `frame:connection_new_address:empty` test (per interledger/rfcs#555 (comment)).
Introduces a JSON file that allows STREAM implementations to validate their ASN.1 OER encoding/decoding of alll Frames defined in IL-RFC-29.
Signed-off-by: sappenin sappenin@gmail.com