-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(npm): Prevents canary releases with double dashed version numbers #1997
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1997 +/- ##
==========================================
+ Coverage 80.16% 80.24% +0.07%
==========================================
Files 66 66
Lines 5375 5395 +20
Branches 1248 1249 +1
==========================================
+ Hits 4309 4329 +20
+ Misses 707 706 -1
- Partials 359 360 +1
Continue to review full report at Codecov.
|
I'm also up in the air about whether this is a It also seems super minor to rev up to TL;DR IMO it's a |
@hipstersmoothie @10hendersonm The double-hyphen was an intentional change made by @hipstersmoothie to cause canary releases to not override beta releases in standard Semver ranges (which considers prerelease tags in alphabetical order). A pull request opened by any non-contributor should never match a prerelase version range like |
🚀 PR was released in |
What Changed
Removed leading dash on all
npm
canary releases.Why
Since upgrading to
auto@10.x
, our canary releases are creating versions like10.1.0--canary.1379.2451.0
with a double-dash on the pre-id.The other instances in the
canary
hook were already stripping off the leading-
, so I've extended this to the last 2 instances.Todo:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major
🐤 Download canary assets:
auto-linux--canary.1997.24321.gz
auto-macos--canary.1997.24321.gz
auto-win.exe--canary.1997.24321.gz
📦 Published PR as canary version:
under canary scope @auto-canary@10.29.1-canary.1997.24321.0
✨ Test out this PR locally via:
npm install @auto-canary/bot-list@10.29.1-canary.1997.24321.0 npm install @auto-canary/auto@10.29.1-canary.1997.24321.0 npm install @auto-canary/core@10.29.1-canary.1997.24321.0 npm install @auto-canary/package-json-utils@10.29.1-canary.1997.24321.0 npm install @auto-canary/all-contributors@10.29.1-canary.1997.24321.0 npm install @auto-canary/brew@10.29.1-canary.1997.24321.0 npm install @auto-canary/chrome@10.29.1-canary.1997.24321.0 npm install @auto-canary/cocoapods@10.29.1-canary.1997.24321.0 npm install @auto-canary/conventional-commits@10.29.1-canary.1997.24321.0 npm install @auto-canary/crates@10.29.1-canary.1997.24321.0 npm install @auto-canary/docker@10.29.1-canary.1997.24321.0 npm install @auto-canary/exec@10.29.1-canary.1997.24321.0 npm install @auto-canary/first-time-contributor@10.29.1-canary.1997.24321.0 npm install @auto-canary/gem@10.29.1-canary.1997.24321.0 npm install @auto-canary/gh-pages@10.29.1-canary.1997.24321.0 npm install @auto-canary/git-tag@10.29.1-canary.1997.24321.0 npm install @auto-canary/gradle@10.29.1-canary.1997.24321.0 npm install @auto-canary/jira@10.29.1-canary.1997.24321.0 npm install @auto-canary/magic-zero@10.29.1-canary.1997.24321.0 npm install @auto-canary/maven@10.29.1-canary.1997.24321.0 npm install @auto-canary/microsoft-teams@10.29.1-canary.1997.24321.0 npm install @auto-canary/npm@10.29.1-canary.1997.24321.0 npm install @auto-canary/omit-commits@10.29.1-canary.1997.24321.0 npm install @auto-canary/omit-release-notes@10.29.1-canary.1997.24321.0 npm install @auto-canary/pr-body-labels@10.29.1-canary.1997.24321.0 npm install @auto-canary/released@10.29.1-canary.1997.24321.0 npm install @auto-canary/s3@10.29.1-canary.1997.24321.0 npm install @auto-canary/sbt@10.29.1-canary.1997.24321.0 npm install @auto-canary/slack@10.29.1-canary.1997.24321.0 npm install @auto-canary/twitter@10.29.1-canary.1997.24321.0 npm install @auto-canary/upload-assets@10.29.1-canary.1997.24321.0 npm install @auto-canary/vscode@10.29.1-canary.1997.24321.0 # or yarn add @auto-canary/bot-list@10.29.1-canary.1997.24321.0 yarn add @auto-canary/auto@10.29.1-canary.1997.24321.0 yarn add @auto-canary/core@10.29.1-canary.1997.24321.0 yarn add @auto-canary/package-json-utils@10.29.1-canary.1997.24321.0 yarn add @auto-canary/all-contributors@10.29.1-canary.1997.24321.0 yarn add @auto-canary/brew@10.29.1-canary.1997.24321.0 yarn add @auto-canary/chrome@10.29.1-canary.1997.24321.0 yarn add @auto-canary/cocoapods@10.29.1-canary.1997.24321.0 yarn add @auto-canary/conventional-commits@10.29.1-canary.1997.24321.0 yarn add @auto-canary/crates@10.29.1-canary.1997.24321.0 yarn add @auto-canary/docker@10.29.1-canary.1997.24321.0 yarn add @auto-canary/exec@10.29.1-canary.1997.24321.0 yarn add @auto-canary/first-time-contributor@10.29.1-canary.1997.24321.0 yarn add @auto-canary/gem@10.29.1-canary.1997.24321.0 yarn add @auto-canary/gh-pages@10.29.1-canary.1997.24321.0 yarn add @auto-canary/git-tag@10.29.1-canary.1997.24321.0 yarn add @auto-canary/gradle@10.29.1-canary.1997.24321.0 yarn add @auto-canary/jira@10.29.1-canary.1997.24321.0 yarn add @auto-canary/magic-zero@10.29.1-canary.1997.24321.0 yarn add @auto-canary/maven@10.29.1-canary.1997.24321.0 yarn add @auto-canary/microsoft-teams@10.29.1-canary.1997.24321.0 yarn add @auto-canary/npm@10.29.1-canary.1997.24321.0 yarn add @auto-canary/omit-commits@10.29.1-canary.1997.24321.0 yarn add @auto-canary/omit-release-notes@10.29.1-canary.1997.24321.0 yarn add @auto-canary/pr-body-labels@10.29.1-canary.1997.24321.0 yarn add @auto-canary/released@10.29.1-canary.1997.24321.0 yarn add @auto-canary/s3@10.29.1-canary.1997.24321.0 yarn add @auto-canary/sbt@10.29.1-canary.1997.24321.0 yarn add @auto-canary/slack@10.29.1-canary.1997.24321.0 yarn add @auto-canary/twitter@10.29.1-canary.1997.24321.0 yarn add @auto-canary/upload-assets@10.29.1-canary.1997.24321.0 yarn add @auto-canary/vscode@10.29.1-canary.1997.24321.0