fix: update binding_to_syntax to use singleton scope according to docs #1309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds singleton scope to those bindings which are singletons according to docs.
See https://github.com/inversify/InversifyJS/blob/master/wiki/scope.md#bindings-that-will-inject-an-object for more information
Related Issue
#1297
Motivation and Context
According to docs, the following bindings should be in
singleton
scope:toConstructor
.toFactory
.toFunction
.toAutoFactory
.toProvider
.Actually, those bindings have the
transient
scopeHow Has This Been Tested?
I've added a test for each type of binding to ensure onActivation is called once
Types of changes
Checklist: